[GitHub] [pinot] 61yao commented on a diff in pull request #9389: [Feature] [Refactoring] Create LiteralContext to hold type and value of literal and Boolean literal eval support

[GitBox]

61yao commented on code in PR #9389:
URL: https://github.com/apache/pinot/pull/9389#discussion_r973330809


##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountThetaSketchAggregationFunction.java:
##########
@@ -100,7 +101,7 @@ public 
DistinctCountThetaSketchAggregationFunction(List<ExpressionContext> argum
       ExpressionContext paramsExpression = arguments.get(1);
       Preconditions.checkArgument(paramsExpression.getType() == 
ExpressionContext.Type.LITERAL,
           "Second argument of DISTINCT_COUNT_THETA_SKETCH aggregation function 
must be literal (parameters)");
-      Parameters parameters = new Parameters(paramsExpression.getLiteral());
+      Parameters parameters = new 
Parameters(paramsExpression.getLiteralString());

Review Comment:
   See comment above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org