61yao commented on code in PR #9389:
URL: https://github.com/apache/pinot/pull/9389#discussion_r971396527
##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/ExpressionContext.java:
##########
@@ -31,37 +34,53 @@
*/
public class ExpressionContext {
public enum Type {
- LITERAL, IDENTIFIER, FUNCTION
+ LITERAL, IDENTIFIER, FUNCTION,
}
private final Type _type;
private final String _value;
Review Comment:
Done.
##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/ExpressionContext.java:
##########
@@ -31,37 +34,53 @@
*/
public class ExpressionContext {
public enum Type {
- LITERAL, IDENTIFIER, FUNCTION
+ LITERAL, IDENTIFIER, FUNCTION,
}
private final Type _type;
private final String _value;
private final FunctionContext _function;
+ // Only set when the _type is LITERAL
+ @Nullable
+ private final LiteralContext _literal;
- public static ExpressionContext forLiteral(String literal) {
- return new ExpressionContext(Type.LITERAL, literal, null);
+ public static ExpressionContext forLiteralContext(Literal literal){
+ return new ExpressionContext(Type.LITERAL, null, null, new
LiteralContext(literal));
+ }
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
