61yao commented on code in PR #9389:
URL: https://github.com/apache/pinot/pull/9389#discussion_r978054283
##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java:
##########
@@ -352,10 +352,10 @@ public static FilterContext getFilter(FunctionContext
filterFunction) {
}
private static String getStringValue(ExpressionContext expressionContext) {
- if (expressionContext.getType() != ExpressionContext.Type.LITERAL) {
+ if(expressionContext.getType() != ExpressionContext.Type.LITERAL){
throw new BadQueryRequestException(
"Pinot does not support column or function on the right-hand side of
the predicate");
}
- return expressionContext.getLiteral();
+ return expressionContext.getLiteralString();
}
Review Comment:
We can do this when we deprecate getLiteralString?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
