61yao commented on code in PR #9389:
URL: https://github.com/apache/pinot/pull/9389#discussion_r978055251
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java:
##########
@@ -114,7 +115,15 @@ public static Expression getLiteralExpression(SqlLiteral
node) {
literal.setDoubleValue(node.bigDecimalValue().doubleValue());
}
} else {
- literal.setStringValue(StringUtils.replace(node.toValue(), "''", "'"));
+ // TODO: Support null literal and other types.
+ switch (node.getTypeName()) {
+ case BOOLEAN:
+ literal.setBoolValue(node.booleanValue());
+ break;
+ default:
+ literal.setStringValue(StringUtils.replace(node.toValue(), "''",
"'"));
+ break;
+ }
Review Comment:
I am not sure how this is related to casting? Can you clarify?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
