navina commented on code in PR #9260:
URL: https://github.com/apache/pinot/pull/9260#discussion_r953800486
##########
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaStreamLevelStreamConfig.java:
##########
@@ -53,21 +53,24 @@ public KafkaStreamLevelStreamConfig(StreamConfig
streamConfig, String tableName,
Map<String, String> streamConfigMap = streamConfig.getStreamConfigsMap();
_kafkaTopicName = streamConfig.getTopicName();
- String hlcBootstrapBrokerUrlKey =
- KafkaStreamConfigProperties
-
.constructStreamProperty(KafkaStreamConfigProperties.HighLevelConsumer.KAFKA_HLC_BOOTSTRAP_SERVER);
+ String hlcBootstrapBrokerUrlKey =
KafkaStreamConfigProperties.constructStreamProperty(
+
KafkaStreamConfigProperties.HighLevelConsumer.KAFKA_HLC_BOOTSTRAP_SERVER);
_bootstrapServers = streamConfigMap.get(hlcBootstrapBrokerUrlKey);
Preconditions.checkNotNull(_bootstrapServers,
"Must specify bootstrap broker connect string " +
hlcBootstrapBrokerUrlKey + " in high level kafka consumer");
+
_groupId = groupId;
+ if (_groupId == null) {
+ _groupId = tableName;
Review Comment:
I would recommend pre-fixing this groupId with `stream-level-` so that we
can distinguish between a table that was consumed at stream level and a table
that was consumed with partition level consumer.
Unless I am mistaken, I don't believe Pinot can guarantee that the group
distribution / partition assignment remains the same when a table switches from
a stream level consumer to partition level consumer.
##########
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/test/java/org/apache/pinot/plugin/stream/kafka20/KafkaStreamLevelStreamConfigTest.java:
##########
@@ -0,0 +1,97 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.plugin.stream.kafka20;
+
+import java.util.HashMap;
+import java.util.Map;
+import org.apache.pinot.spi.stream.StreamConfig;
+import org.apache.pinot.spi.stream.StreamConfigProperties;
+import org.testng.Assert;
+import org.testng.annotations.Test;
+
+
+public class KafkaStreamLevelStreamConfigTest {
+ private static final String KAFKA_DECODER_CLASS_NAME =
+ "org.apache.pinot.plugin.inputformat.avro.KafkaAvroMessageDecoder";
+
+ private StreamConfig getStreamConfig(String topic, String bootstrapHosts,
String buffer, String socketTimeout) {
+ return getStreamConfig(topic, bootstrapHosts, buffer, socketTimeout, null,
null, null);
+ }
+
+ private StreamConfig getStreamConfig(String topic, String bootstrapHosts,
String buffer, String socketTimeout,
+ String fetcherSize, String fetcherMinBytes, String isolationLevel) {
+ return getStreamConfig(topic, bootstrapHosts, buffer, socketTimeout,
fetcherSize, fetcherMinBytes, isolationLevel,
+ null);
+ }
+
+ public StreamConfig getStreamConfig(String topic, String bootstrapHosts,
String buffer, String socketTimeout,
Review Comment:
If this is intended to be a public method, can you move this into a Util
class under tests in `pinot-kafka-base` ? That way, we can avoid code
duplication.
##########
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/test/java/org/apache/pinot/plugin/stream/kafka20/KafkaStreamLevelStreamConfigTest.java:
##########
@@ -0,0 +1,97 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.plugin.stream.kafka20;
+
+import java.util.HashMap;
+import java.util.Map;
+import org.apache.pinot.spi.stream.StreamConfig;
+import org.apache.pinot.spi.stream.StreamConfigProperties;
+import org.testng.Assert;
+import org.testng.annotations.Test;
+
+
+public class KafkaStreamLevelStreamConfigTest {
+ private static final String KAFKA_DECODER_CLASS_NAME =
+ "org.apache.pinot.plugin.inputformat.avro.KafkaAvroMessageDecoder";
+
+ private StreamConfig getStreamConfig(String topic, String bootstrapHosts,
String buffer, String socketTimeout) {
+ return getStreamConfig(topic, bootstrapHosts, buffer, socketTimeout, null,
null, null);
+ }
+
+ private StreamConfig getStreamConfig(String topic, String bootstrapHosts,
String buffer, String socketTimeout,
+ String fetcherSize, String fetcherMinBytes, String isolationLevel) {
+ return getStreamConfig(topic, bootstrapHosts, buffer, socketTimeout,
fetcherSize, fetcherMinBytes, isolationLevel,
+ null);
+ }
Review Comment:
Any reason why there are 2 overloaded methods for `getStreamConfig` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
