navina commented on PR #9260: URL: https://github.com/apache/pinot/pull/9260#issuecomment-1225738499
> Please reformat the changes with [Pinot Style](https://docs.pinot.apache.org/developers/developers-and-contributors/code-setup?q=pinot+style#intellij) > > @navina Can you please help review the PR? To keep the existing behavior, should we put empty string as the group id if it is missing? I agree that the empty string will match the existing behavior. But it doesn't provide any value to the application. if you have more than one kafka table, they will all share the same group id, which in my opinion, is a bug or incorrect implementation. I think we can use the table name as the group id and prefix it with `stream-level` or `partition-level` based on the consumption model used. For existing applications that may rely on an empty string group id, they can always add a table config to override the `group.id` kafka consumer property. Wdyt @Jackie-Jiang ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
