navina commented on PR #9260:
URL: https://github.com/apache/pinot/pull/9260#issuecomment-1280515023

   >Please test a multi partition topic with replication enabled.
   
   yeah. this patch will break with replication. But what I am unsure about is 
how this was working before for the monitoring tools? Whether the `group.id` is 
`null` or `empty`, as long as it doesn't include the replica id, it will not be 
accurate. 
   
   > If the issue here is monitoring lags I believe there is a rest endpoint in 
swagger to give the consumer offsets as well as the last consuming time stamp 
in the query results.
   
   Pinot doesn't have a good abstraction for input partitioning/partition 
grouping. Once we have that, I think we can customize the connector to use 
Pinot's grouping model and not the connector's model. Thoughts? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to