Jackie-Jiang commented on code in PR #9163:
URL: https://github.com/apache/pinot/pull/9163#discussion_r940507242
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamConfigProperties.java:
##########
@@ -45,6 +45,7 @@ private StreamConfigProperties() {
public static final String STREAM_CONNECTION_TIMEOUT_MILLIS =
"connection.timeout.millis";
public static final String STREAM_IDLE_TIMEOUT_MILLIS =
"idle.timeout.millis";
public static final String STREAM_DECODER_CLASS = "decoder.class.name";
+ public static final String STREAM_DECODER_ERRORS_IGNORE =
"decoder.errors.ignore";
Review Comment:
(minor) I feel it will be more nature this way since we changed it to
boolean. Same for other places
```suggestion
public static final String STREAM_DECODER_IGNORE_ERRORS =
"decoder.ignore.errors";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
