ddcprg commented on code in PR #9163: URL: https://github.com/apache/pinot/pull/9163#discussion_r938194189
########## pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamConfig.java: ########## @@ -68,6 +71,7 @@ public enum ConsumerType { private final List<ConsumerType> _consumerTypes = new ArrayList<>(); private final String _consumerFactoryClassName; private final String _decoderClass; + private final String _decoderErrorsIgnore; Review Comment: Yes, totally agree with this as well. We discussed adding this flag when I was making a change to ignore an exception in the confluent decoder, we said initially we would use Boolean so happy to change it - cc: @kishoreg -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org