navina commented on code in PR #9163:
URL: https://github.com/apache/pinot/pull/9163#discussion_r939226414
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -548,9 +549,14 @@ private boolean processStreamEvents(MessageBatch
messagesAndOffsets, long idlePi
// this can be overridden by the decoder if there is a better indicator
in the message payload
RowMetadata msgMetadata = messagesAndOffsets.getMetadataAtIndex(index);
- GenericRow decodedRow = _messageDecoder
- .decode(messagesAndOffsets.getMessageAtIndex(index),
messagesAndOffsets.getMessageOffsetAtIndex(index),
- messagesAndOffsets.getMessageLengthAtIndex(index), reuse);
+ GenericRow decodedRow = null;
Review Comment:
I don't think the `StreamMessageDecoder` talks anything about retry / error
handling. It only says that when return value is `null`, it means record is
dropped. that's why I had this question.
You bring up a good point about breaking contract with other message
decoders. Perhaps in a follow-up PR, we should modify with a base decoder
implementation that can handle exceptions and lets the OOTB catch-up. that way,
we don't break anything, but provide a path to adapt for other implementations
.
I will resolve my comment for now. ty! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
