navina commented on code in PR #9163:
URL: https://github.com/apache/pinot/pull/9163#discussion_r938224714
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -548,9 +549,14 @@ private boolean processStreamEvents(MessageBatch
messagesAndOffsets, long idlePi
// this can be overridden by the decoder if there is a better indicator
in the message payload
RowMetadata msgMetadata = messagesAndOffsets.getMetadataAtIndex(index);
- GenericRow decodedRow = _messageDecoder
- .decode(messagesAndOffsets.getMessageAtIndex(index),
messagesAndOffsets.getMessageOffsetAtIndex(index),
- messagesAndOffsets.getMessageLengthAtIndex(index), reuse);
+ GenericRow decodedRow = null;
Review Comment:
Qq: can we not handle the decoder exception within the decoder
implementation ?
Throwing exceptions is fairly expensive and it can be reduced if the decoder
exception is handled within the decoder implementation or in a generic/base
decoder implementation that would handle it for all decoder implementations.
Don't intend to block your work. But I want to bring up a point and we can
choose to tackle it later. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
