gortiz commented on code in PR #8981:
URL: https://github.com/apache/pinot/pull/8981#discussion_r921998383
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java:
##########
@@ -128,6 +133,11 @@ public class ControllerTest {
protected ZkHelixPropertyStore<ZNRecord> _propertyStore;
private ZkStarter.ZookeeperInstance _zookeeperInstance;
+ private final Logger _logger;
+
+ public ControllerTest() {
+ _logger = LoggerFactory.getLogger(this.getClass());
Review Comment:
> but subclass can't access private final object right?
No, they cannot and it should be protected so subclasses can use it. I will
change it. But right now, when the code in `ControllerTest` logs something, the
logger name is the name of the concrete class, not `ControllerTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
