gortiz commented on code in PR #8981: URL: https://github.com/apache/pinot/pull/8981#discussion_r921138355
########## pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java: ########## @@ -269,6 +280,38 @@ public void startController(Map<String, Object> properties) configAccessor.set(scope, Helix.DEFAULT_HYPERLOGLOG_LOG2M_KEY, Integer.toString(12)); } + protected void waitForController() + throws InterruptedException, TimeoutException { + boolean ready = false; + Instant start = Instant.now(); + Duration timeoutDuration = Duration.ofSeconds(60); + Instant timeoutInstant = Instant.now().plus(timeoutDuration); + + _logger.info("Verifying that controller can be reached"); + boolean failedAtLeastOnce = false; + + while (!ready && Instant.now().isBefore(timeoutInstant)) { + try { + getControllerRequestClient().getSchema("whatever"); Review Comment: I don't know. Do the health check enforce that schemas can be read? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org