gortiz commented on code in PR #8981:
URL: https://github.com/apache/pinot/pull/8981#discussion_r921137313
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java:
##########
@@ -269,6 +280,38 @@ public void startController(Map<String, Object> properties)
configAccessor.set(scope, Helix.DEFAULT_HYPERLOGLOG_LOG2M_KEY,
Integer.toString(12));
}
+ protected void waitForController()
Review Comment:
I don't think they are the same. `waitForCondition(Function<Void, Boolean>
condition, ...)` family aborts if an exception is thrown. Also, this method
logs in a different way if it was an exception. Info logs are not printed by
default. I think it may be useful in future to have the logs if the flaky error
show up again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
