gortiz opened a new pull request, #8981: URL: https://github.com/apache/pinot/pull/8981
Following #8776 I found that there was a bug in `PinotTaskManagerStatelessTest` that seems to be caused a race condition. In my laptop (an ARM) test `PinotTaskManagerStatelessTest.testPinotTaskManagerSchedulerWithUpdate`: - Consistently fail when all tests in the class were executed - Consistently run correctly when only that test was executed - Consistently run correctly when all tests in the class were executed AND a breakpoint was added before the schema was added. What I've done to solve it is to add a method `waitForController` in `ControllerTest.startController` that tries to execute a request until it works or there is a timeout (configured to be thrown after 1 minute). I didn't find a health check method in `ControllerRequestClient`, so what is actually requested is a schema that doesn't exists, which should consistently return a 404. I'm open to change that request to a proper one if someone has an alternative. To be clear, it is uncertain whether this will fix the issue #8776 or not. As explained in the issue, it seems that there was an important modification in `ControllerTest` the day the issue was created: `ControllerTest` was changed to be used as an singleton instance instead of an static class but a lot of tests extended it, so there may be other race conditions hidden there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
