mcvsubbu commented on pull request #8176: URL: https://github.com/apache/pinot/pull/8176#issuecomment-1036564700
> Echo on previous comments > > > So, cluster-level changes are applied immediately, but table level changes are honored at the time of deletion of the segment. > > this cannot be done unless controller is restarted as the retention time, so I decided to keep the time-to-delete suffix in all deleted segments. > > for other comments I've addressed. plz kindly take another look It is OK to reqiure a controller restart if a cluster level change is applied. In future (another PR) we can move this config to Helix, and a restart will not be required. Please apply this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
