mcvsubbu commented on a change in pull request #8176:
URL: https://github.com/apache/pinot/pull/8176#discussion_r804065764
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/SegmentDeletionManager.java
##########
@@ -54,21 +56,22 @@
private static final long MAX_DELETION_DELAY_SECONDS = 300L; // Maximum of
5 minutes back-off to retry the deletion
private static final long DEFAULT_DELETION_DELAY_SECONDS = 2L;
private static final String DELETED_SEGMENTS = "Deleted_Segments";
+ private static final String RETENTION_MS_SEPARATOR = "__RETENTION_MS__";
Review comment:
Can you add an example here (in comments) of what the file name would
look like? Does it have the absolute time at which the file needs to go away,
or some time period that needs to be compared with the file creation time? Why
not encode the absolute time in a human readable format like "20220311T2300Z"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
