mcvsubbu commented on a change in pull request #8176:
URL: https://github.com/apache/pinot/pull/8176#discussion_r804213703
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/SegmentDeletionManager.java
##########
@@ -54,21 +56,22 @@
private static final long MAX_DELETION_DELAY_SECONDS = 300L; // Maximum of
5 minutes back-off to retry the deletion
private static final long DEFAULT_DELETION_DELAY_SECONDS = 2L;
private static final String DELETED_SEGMENTS = "Deleted_Segments";
+ private static final String RETENTION_MS_SEPARATOR = "__RETENTION_MS__";
Review comment:
I prefer the absolute time. It is human readable, so if an administrator
lists the files in the deleted_segments directory, they know exactly when some
files will go away, or how long some files may remain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
