walterddr commented on pull request #8176: URL: https://github.com/apache/pinot/pull/8176#issuecomment-1035559403
> Will the file name encoded extension be there even if the table config does not have any override? Can we avoid that, please? So, cluster-level changes are applied immediately, but table level changes are honored at the time of deletion of the segment. yes. actually this is a good idea. let me do that. > Also, for readability, you may wan to call one as "remove" and the other as "delete" (and define these in comments in SegmentDeletionManager and name the variables appropriately). Otherwise, it gets confusing. sound good. will do. > > Lastly, have you considered the possibility of file explosion? There will now be multiple copies of the same segment with different deletion dates. Is that desirable? Can it be used for DDOS? it won't be. once the segments are deleted they cannot be deleted once again. there's only one copied per deleted segment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
