walterddr commented on a change in pull request #8016: URL: https://github.com/apache/pinot/pull/8016#discussion_r786981509
########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/nativefst/utils/RealTimeRegexpMatcher.java ########## @@ -0,0 +1,156 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.utils.nativefst.utils; + +import java.util.ArrayDeque; +import java.util.ArrayList; +import java.util.List; +import java.util.Queue; +import java.util.Set; +import org.apache.pinot.segment.local.utils.nativefst.automaton.Automaton; +import org.apache.pinot.segment.local.utils.nativefst.automaton.CharacterRunAutomaton; +import org.apache.pinot.segment.local.utils.nativefst.automaton.RegExp; +import org.apache.pinot.segment.local.utils.nativefst.automaton.State; +import org.apache.pinot.segment.local.utils.nativefst.automaton.Transition; +import org.apache.pinot.segment.local.utils.nativefst.mutablefst.MutableArc; +import org.apache.pinot.segment.local.utils.nativefst.mutablefst.MutableFST; +import org.apache.pinot.segment.local.utils.nativefst.mutablefst.MutableState; +import org.roaringbitmap.IntConsumer; + +public class RealTimeRegexpMatcher { + private final String _regexQuery; + private final MutableFST _fst; + private final Automaton _automaton; + private final IntConsumer _dest; + + public RealTimeRegexpMatcher(String regexQuery, MutableFST fst, IntConsumer dest) { + _regexQuery = regexQuery; + _fst = fst; + _dest = dest; + + _automaton = new RegExp(_regexQuery).toAutomaton(); + } + + public static void regexMatch(String regexQuery, MutableFST fst, IntConsumer dest) { + RealTimeRegexpMatcher matcher = new RealTimeRegexpMatcher(regexQuery, fst, dest); + matcher.regexMatchOnFST(); + } + + // Matches "input" string with _regexQuery Automaton. + public boolean match(String input) { + CharacterRunAutomaton characterRunAutomaton = new CharacterRunAutomaton(_automaton); + return characterRunAutomaton.run(input); + } + + /** + * This function runs matching on automaton built from regexQuery and the FST. + * FST stores key (string) to a value (Long). Both are state machines and state transition is based on + * a input character. + * + * This algorithm starts with Queue containing (Automaton Start Node, FST Start Node). + * Each step an entry is popped from the queue: + * 1) if the automaton state is accept and the FST Node is final (i.e. end node) then the value stored for that FST + * is added to the set of result. + * 2) Else next set of transitions on automaton are gathered and for each transition target node for that character + * is figured out in FST Node, resulting pair of (automaton state, fst node) are added to the queue. + * 3) This process is bound to complete since we are making progression on the FST (which is a DAG) towards final + * nodes. + */ + public void regexMatchOnFST() { Review comment: Sorry for jumping in the discussion late. I myself have the habit to add many line separators for readability as well so glad to see some discussions about this. In general I found it hard to enforce a checkstyle on readability as I agree it is rather subjective. (other than those obvious ones such as https://google.github.io/styleguide/javaguide.html). my own opinion here is to follow as close to the OSS codebase standard from as possible - this gives a consistency sense to users as well as first-time contributors. But without incurring too much overhead, I don't think we want to discourage contribution because of formatting in general. but i saw richard here provided many constructive feedback as well beside the formatting; in my experience ppl who reviewed extensively on such a large PR will also be the ones who maintain it and collaborate together going forward. it would be great to reach a reasonable readability middle ground. This is just my personal opinion, I am also pretty new to Pinot so please disregard if it doesn't seem to make sense. But definitely will use this as a standard for my contribution going forward if we can reach a general guideline -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
