atris commented on a change in pull request #8016: URL: https://github.com/apache/pinot/pull/8016#discussion_r786636540
########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/nativefst/utils/RealTimeRegexpMatcher.java ########## @@ -0,0 +1,156 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.utils.nativefst.utils; + +import java.util.ArrayDeque; +import java.util.ArrayList; +import java.util.List; +import java.util.Queue; +import java.util.Set; +import org.apache.pinot.segment.local.utils.nativefst.automaton.Automaton; +import org.apache.pinot.segment.local.utils.nativefst.automaton.CharacterRunAutomaton; +import org.apache.pinot.segment.local.utils.nativefst.automaton.RegExp; +import org.apache.pinot.segment.local.utils.nativefst.automaton.State; +import org.apache.pinot.segment.local.utils.nativefst.automaton.Transition; +import org.apache.pinot.segment.local.utils.nativefst.mutablefst.MutableArc; +import org.apache.pinot.segment.local.utils.nativefst.mutablefst.MutableFST; +import org.apache.pinot.segment.local.utils.nativefst.mutablefst.MutableState; +import org.roaringbitmap.IntConsumer; + +public class RealTimeRegexpMatcher { + private final String _regexQuery; + private final MutableFST _fst; + private final Automaton _automaton; + private final IntConsumer _dest; + + public RealTimeRegexpMatcher(String regexQuery, MutableFST fst, IntConsumer dest) { + _regexQuery = regexQuery; + _fst = fst; + _dest = dest; + + _automaton = new RegExp(_regexQuery).toAutomaton(); + } + + public static void regexMatch(String regexQuery, MutableFST fst, IntConsumer dest) { + RealTimeRegexpMatcher matcher = new RealTimeRegexpMatcher(regexQuery, fst, dest); + matcher.regexMatchOnFST(); + } + + // Matches "input" string with _regexQuery Automaton. + public boolean match(String input) { + CharacterRunAutomaton characterRunAutomaton = new CharacterRunAutomaton(_automaton); + return characterRunAutomaton.run(input); + } + + /** + * This function runs matching on automaton built from regexQuery and the FST. + * FST stores key (string) to a value (Long). Both are state machines and state transition is based on + * a input character. + * + * This algorithm starts with Queue containing (Automaton Start Node, FST Start Node). + * Each step an entry is popped from the queue: + * 1) if the automaton state is accept and the FST Node is final (i.e. end node) then the value stored for that FST + * is added to the set of result. + * 2) Else next set of transitions on automaton are gathered and for each transition target node for that character + * is figured out in FST Node, resulting pair of (automaton state, fst node) are added to the queue. + * 3) This process is bound to complete since we are making progression on the FST (which is a DAG) towards final + * nodes. + */ + public void regexMatchOnFST() { Review comment: @richardstartin First off, I really appreciate your in-depth look into the PR. As usual, your comments are invaluable. I agree with you that the spacing on the PR was a bit too much -- and I have fixed it per your comments. However, I would also ask yourself to be a bit considerate for expression of a personal style. The example you made above about inconsistent spacing makes perfect space, and I am happy to fix that (and would have fixed it in a blink, had it been the primary comment that you made about spacing). However, you have commented on nearly every blank line that I added in this PR, including all the places where I was consistent. For eg., I added a blank space after variable declaration and before usage, and this is a consistent pattern. You did not agree with the same and asked me to revert that in mostly every file that this PR consists of. I accepted your comments and changed the same. All I am requesting you (humbly) is to allow me a bit of room (within reasonable limits, of course). I tend to find adding a blank line soothing to my eyes, and while I understand that this PR went ove rboard with the same, I have tried my best to fix it now. I request you to kindly not allege that I am being intentional by adding too many lines and trying to obfuscate the project (quoting your latest comment). I sincerely apologise if I have crossed any boundaries or have been detrimental to the project in any form -- that is not my intention. And, as you must have noticed, I have followed your advise to not add spaces in my text anymore. This comment is a testament to that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
