kishoreg commented on pull request #7210: URL: https://github.com/apache/pinot/pull/7210#issuecomment-891188205
@mcvsubbu the two implementations are very different and I would not consider that as clean up. This is introducing a very different way of implementing Explain and is not along the lines of the final implementation. What are we gaining by adding a lot of code that will be deleted later? I understand that there was a lot of effort involved by the intern to implement this. I am happy to sit down and help implement it the right way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
