jackjlli commented on a change in pull request #7210:
URL: https://github.com/apache/pinot/pull/7210#discussion_r678507134
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -498,6 +517,36 @@ private BrokerResponseNative handleSQLRequest(long
requestId, String query, Json
return brokerResponse;
}
+ private BrokerResponseNative processExplainPlanQuery
+ (BrokerRequest brokerRequest, BrokerRequest offlineBrokerRequest,
BrokerRequest realtimeBrokerRequest,
+ String offlineTableName, String realtimeTableName) {
+ QueryContext queryContext =
BrokerRequestToQueryContextConverter.convert(brokerRequest);
Review comment:
I found out that `queryContext` is also converted in `reduceOnDataTable`
method of `BrokerReduceService` class on broker. Maybe we should move the
conversion upfront so that the same object can be reused?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]