mcvsubbu commented on pull request #7210: URL: https://github.com/apache/pinot/pull/7210#issuecomment-891171181
@kishoreg we have had PRs before that needed cleanups later. JSON support and Range index support comes to mind. https://github.com/apache/pinot/pull/5240. I am sure there are others where we added support so that it satisfies a need now, and we clean up things under the hood later. Some of them are still pending (and that is ok, people will get to it when they can). In fact, in some cases the design documents came in after the first PR (and/or was not circulated widely). But we have allowed it in the past with some understanding that the feature was a timely one for the community. In this case, a design document was floated appropriately along with the issue, and a month's time was provided for the community to provide feedback. The phasing of the project was also clearly mentioned in there. We know that a cleanup is needed. It is also clear that @siddharthteotia has committed to do the cleanup (and also in a timely manner). I think we should avoid blocking PRs in such cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
