kishoreg commented on a change in pull request #7210: URL: https://github.com/apache/pinot/pull/7210#discussion_r677048347
########## File path: pinot-core/src/main/java/org/apache/pinot/core/query/explain/ExplainPlanUtils.java ########## @@ -0,0 +1,90 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.pinot.core.query.explain; + +import java.util.HashSet; +import java.util.List; +import org.apache.pinot.common.request.context.predicate.Predicate; +import org.apache.pinot.spi.config.table.FieldConfig; +import org.apache.pinot.spi.config.table.IndexingConfig; + + +/** + * Helper methods for processing EXPLAIN PLAN queries + */ +public class ExplainPlanUtils { + + private ExplainPlanUtils() { + } + + public static String getIndexUsed(String column, Predicate.Type predicateType, IndexingConfig indexingConfig, Review comment: this is duplicating the logic and we have a lot of optimizations on when to use and when not to use indexes. This will create more confusion for the user trying and also huge overhead on the engineers having to maintain the logic in two places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
