[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6901: Add config file support, update yaml files with correct data for Compatibility Testing, fix generation support for queries(#6787)

[GitBox]

mcvsubbu commented on a change in pull request #6901:
URL: https://github.com/apache/incubator-pinot/pull/6901#discussion_r630647147



##########
File path: compatibility-verifier/compCheck.sh
##########
@@ -169,6 +183,11 @@ 
COMPAT_TESTER_PATH="pinot-integration-tests/target/pinot-integration-tests-pkg/b
 # create subdirectories for given commits
 workingDir=$1
 testSuiteDir=$(absPath "$2")
+
+brokerConfigFile=${testSuiteDir}/BrokerConfig.conf

Review comment:
       ```suggestion
   brokerConfigFile=${testSuiteDir}/config/BrokerConfig.conf
   ```
   Same for other files also. We want to have them all in the config/ directory

##########
File path: compatibility-verifier/compCheck.sh
##########
@@ -112,14 +122,18 @@ function stopService() {
 # Starts a Pinot cluster given a specific target directory
 function startServices() {
   dirName=$1
+  local controllerConfigFile=$2

Review comment:
       All config files are supposed to be in the config/ directory, right? So, 
we can just pass one arg here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org