[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6901: Add config file support, update yaml files with correct data for Compatibility Testing, fix generation support for queries(#6787)

[GitBox]

mqliang commented on a change in pull request #6901:
URL: https://github.com/apache/incubator-pinot/pull/6901#discussion_r630581148



##########
File path: 
pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/QueryOp.java
##########
@@ -76,7 +76,11 @@ public void setExpectedResultsFileName(String 
expectedResultsFileName) {
   boolean runOp(int generationNumber) {
     System.out.println("Verifying queries in " + _queryFileName + " against 
results in " + _expectedResultsFileName);
     try {
-      return verifyQueries(generationNumber);
+      boolean queryVerificationResult = true;
+      for(int i = 1; i <= generationNumber; i++) {
+        queryVerificationResult &= verifyQueries(i);

Review comment:
       Can early return here: 
   ```
   for(int i = 1; i <= generationNumber; i++) {
           if (! verifyQueries(i) ) {
                  return false;
           }
   }
   return true;
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org