GSharayu commented on a change in pull request #6901:
URL: https://github.com/apache/incubator-pinot/pull/6901#discussion_r630566885
##########
File path: compatibility-verifier/compCheck.sh
##########
@@ -156,6 +170,13 @@ function absPath() {
echo "$testSuiteDirPath"
}
+#check if config file is present or not
+function checkConfigFile() {
+ if [[ -e $1 ]]; then
Review comment:
removed this part and added to setConfigFileArg
##########
File path: compatibility-verifier/compCheck.sh
##########
@@ -70,21 +70,31 @@ function waitForClusterReady() {
sleep 2
echo "Cluster ready."
}
+
+#set config file is present or not
+function setConfigFile() {
+ if [[ -n $1 ]]; then
+ echo "-configFileName ${1}"
+ fi
+}
+
# Given a component and directory, start that version of the specific component
function startService() {
serviceName=$1
dirName=$2
+ local configFile=$(setConfigFile "$3")
Review comment:
done!
##########
File path: compatibility-verifier/compCheck.sh
##########
@@ -70,21 +70,31 @@ function waitForClusterReady() {
sleep 2
echo "Cluster ready."
}
+
+#set config file is present or not
+function setConfigFile() {
Review comment:
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
