sajjad-moradi commented on a change in pull request #6625:
URL: https://github.com/apache/incubator-pinot/pull/6625#discussion_r589964384
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/io/configs/IndexConfig.java
##########
@@ -80,6 +80,10 @@ public boolean isSortedColumnOverwritten() {
return _isSortedColumnOverwritten;
}
+ public void setSortedColumnOverwritten(boolean sortedColumnOverwritten) {
Review comment:
Usually deserializers require standard setters to be able to deserialize
to objects. We didn't need this before, because `RecommenderDriver.run(input)`
returns a string and that's only used in the endpoint. In tests, the output of
each rule is begin tested. Now for the RT.Prov.Rule, the new test verify
against the output of the run function - which is more comprehensive - and that
requires deserialization of the output string.
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/io/configs/PartitionConfig.java
##########
@@ -83,6 +83,18 @@ public void setNumKafkaPartitions(int numKafkaPartitions) {
this._numKafkaPartitions = numKafkaPartitions;
}
+ public void setNumPartitionsOfflineOverwritten(boolean
numPartitionsOfflineOverwritten) {
Review comment:
Same as above comment.
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/RealtimeProvisioningHelperCommand.java
##########
@@ -242,13 +244,22 @@ public boolean execute()
long maxUsableHostMemBytes = DataSizeUtils.toBytes(_maxUsableHostMemory);
- if (_numRows == 0) {
- _numRows = DEFAULT_NUMBER_OF_ROWS;
+ MemoryEstimator memoryEstimator;
+ if (segmentProvided) {
Review comment:
Will do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
