siddharthteotia commented on a change in pull request #6625:
URL: https://github.com/apache/incubator-pinot/pull/6625#discussion_r589661388
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/RealtimeProvisioningHelperCommand.java
##########
@@ -242,13 +244,22 @@ public boolean execute()
long maxUsableHostMemBytes = DataSizeUtils.toBytes(_maxUsableHostMemory);
- if (_numRows == 0) {
- _numRows = DEFAULT_NUMBER_OF_ROWS;
+ MemoryEstimator memoryEstimator;
+ if (segmentProvided) {
Review comment:
(nit) please add one line comment explaining the difference between the
2 modes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
