siddharthteotia commented on a change in pull request #6625:
URL: https://github.com/apache/incubator-pinot/pull/6625#discussion_r589665730
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/io/params/RecommenderConstants.java
##########
@@ -80,6 +81,13 @@
public static final String ERROR_INVALID_QUERY = "Error: query not able to
parse, skipped";
}
+ public static class RealtimeProvisioningRule {
Review comment:
Javadoc please. I see classes for other rules here don't have javadocs.
We can probably add those docs later. But for new code, let's document as much
as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
