siddharthteotia commented on a change in pull request #6625:
URL: https://github.com/apache/incubator-pinot/pull/6625#discussion_r591833080
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/realtime/provisioning/MemoryEstimator.java
##########
@@ -142,10 +141,10 @@ public MemoryEstimator(TableConfig tableConfig, File
sampleCompletedSegment, int
/**
* Constructor used for processing the given data characteristics (instead
of completed segment)
*/
- public MemoryEstimator(TableConfig tableConfig, File schemaWithMetadataFile,
int numberOfRows, int ingestionRate,
- long maxUsableHostMemory, int tableRetentionHours) {
+ public MemoryEstimator(TableConfig tableConfig, Schema schema,
SchemaWithMetaData schemaWithMetadata,
Review comment:
(nit) please rename `ingestionRate` to `ingestionRatePerPartition`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
