[GitHub] [incubator-pinot] harleyjj commented on a change in pull request #6333: [TE] frontend - harleyjj/rca - display metric funnel in metrics table…

[GitBox]

harleyjj commented on a change in pull request #6333:
URL: https://github.com/apache/incubator-pinot/pull/6333#discussion_r556250470



##########
File path: 
thirdeye/thirdeye-frontend/app/pods/components/rootcause-metrics/component.js
##########
@@ -65,10 +56,29 @@ export default Component.extend({
    */
   onSelection: null, // function (Set, state)
 
+  context: null,
+
+  compareMode: null, // ""

Review comment:
       So I get these warnings if I change them to objects.  They are supposed 
to be passed in by the parent.  What do you recommend?  
   <img width="1138" alt="Screen Shot 2021-01-12 at 8 07 48 PM" 
src="https://user-images.githubusercontent.com/10106733/104405529-07966080-5512-11eb-93b1-25a8860d4cd7.png";>
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org