harleyjj commented on a change in pull request #6333:
URL: https://github.com/apache/incubator-pinot/pull/6333#discussion_r556234688
##########
File path:
thirdeye/thirdeye-frontend/app/pods/services/rootcause-aggregates-cache/service.js
##########
@@ -68,34 +67,34 @@ export default Service.extend({
// group by metrics and offsets
const groupedByUrn = [...missing]
- .map(urn => toAbsoluteUrn(urn, requestContext.compareMode))
- .map(urn => { return { urn, base: toMetricUrn(urn), offset:
urn.split(':')[2] }; })
+ .map((urn) => toAbsoluteUrn(urn, requestContext.compareMode))
+ .map((urn) => {
+ return { urn, base: toMetricUrn(urn), offset: urn.split(':')[2] };
+ })
Review comment:
This is also not written by me but updated by prettify. By looking at
it, I believe "toAbsoluteUrn" is doing some work before the next map.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
