pradeepgv42 commented on a change in pull request #6120:
URL: https://github.com/apache/incubator-pinot/pull/6120#discussion_r524448278
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/realtime/impl/invertedindex/RealtimeLuceneTextIndexReader.java
##########
@@ -89,6 +90,11 @@ public void add(String document) {
_indexCreator.add(document);
}
+ @Override
+ public ImmutableRoaringBitmap getDictIds(String searchQuery) {
+ throw new UnsupportedOperationException();
Review comment:
Yeah I agree this is not ideal, but since FST index stores key -> dictid
mapping I created this overridable method.
I moved the FSTIndexCreator to extend TextReader interface too since that
looks more closer than inverted index.
Maybe this could be moved to it's own interface if there are similar
indicies in future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
