[GitHub] [incubator-pinot] pradeepgv42 commented on a change in pull request #6120: Add FST Index using lucene lib to speedup regexp queries

[GitBox]

pradeepgv42 commented on a change in pull request #6120:
URL: https://github.com/apache/incubator-pinot/pull/6120#discussion_r524443785



##########
File path: 
pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java
##########
@@ -122,8 +127,29 @@ private BaseFilterOperator 
constructPhysicalOperator(FilterContext filter,
           DataSource dataSource = 
_indexSegment.getDataSource(lhs.getIdentifier());
           switch (predicate.getType()) {
             case TEXT_MATCH:
-              return new TextMatchFilterOperator(dataSource.getTextIndex(),
-                  ((TextMatchPredicate) predicate).getValue(), _numDocs);
+                return new TextMatchFilterOperator(
+                        dataSource.getTextIndex(),
+                        ((TextMatchPredicate) predicate).getValue(),
+                        _numDocs);
+            case REGEXP_LIKE:
+              PredicateEvaluator evaluator = null;
+              if (dataSource.getFSTIndex() != null) {
+                evaluator = 
FSTBasedRegexpPredicateEvaluatorFactory.newFSTBasedEvaluator(
+                        dataSource.getFSTIndex(),
+                        dataSource.getDictionary(),
+                        ((RegexpLikePredicate) predicate).getValue());
+              } else if (dataSource instanceof MutableDataSource &&

Review comment:
       Added comments, also see my response on above comment (from 
FSTBasedRegexpPredicateEvaluatorFactory.java)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org