pradeepgv42 commented on a change in pull request #6120: URL: https://github.com/apache/incubator-pinot/pull/6120#discussion_r524458661
########## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/datasource/MutableDataSource.java ########## @@ -36,16 +36,26 @@ */ @SuppressWarnings("rawtypes") public class MutableDataSource extends BaseDataSource { + final boolean _fstIndexEnabled; - public MutableDataSource(FieldSpec fieldSpec, int numDocs, int numValues, int maxNumValuesPerMVEntry, + public MutableDataSource(FieldSpec fieldSpec, int numDocs, int numValues, int maxNumValuesPerMVEntry, boolean fstIndexEnabled, @Nullable PartitionFunction partitionFunction, @Nullable Set<Integer> partitions, @Nullable Comparable minValue, @Nullable Comparable maxValue, ForwardIndexReader forwardIndex, @Nullable Dictionary dictionary, @Nullable InvertedIndexReader invertedIndex, @Nullable InvertedIndexReader rangeIndex, - @Nullable TextIndexReader textIndex, @Nullable BloomFilterReader bloomFilter, + @Nullable TextIndexReader textIndex, @Nullable TextIndexReader fstIndex, + @Nullable BloomFilterReader bloomFilter, @Nullable NullValueVectorReader nullValueVector) { super(new MutableDataSourceMetadata(fieldSpec, numDocs, numValues, maxNumValuesPerMVEntry, partitionFunction, - partitions, minValue, maxValue), forwardIndex, dictionary, invertedIndex, rangeIndex, textIndex, bloomFilter, - nullValueVector); + partitions, minValue, maxValue), forwardIndex, dictionary, + invertedIndex, rangeIndex, textIndex, fstIndex, + bloomFilter, nullValueVector); + _fstIndexEnabled = fstIndexEnabled; + } + + + // Returns whether the current field has Review comment: This is to keep the results consistent between consuming & rolled out segments (more details in comments above) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org