pradeepgv42 commented on a change in pull request #6120:
URL: https://github.com/apache/incubator-pinot/pull/6120#discussion_r524439213
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/BitmapBasedFilterOperator.java
##########
@@ -66,8 +67,9 @@ protected FilterBlock getNextBlock() {
int[] dictIds = _exclusive ? _predicateEvaluator.getNonMatchingDictIds() :
_predicateEvaluator.getMatchingDictIds();
int numDictIds = dictIds.length;
- // NOTE: PredicateEvaluator without matching/non-matching dictionary ids
should not reach here.
- Preconditions.checkState(numDictIds > 0);
+ if (numDictIds == 0) {
Review comment:
Without this precondition fails, I checked with Jackie who added this
condition he mentioned it should be fine to remove this. Reason could be
because I enabled regexp operator to use bitmap based filter when FST index is
available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
