akshayrai commented on a change in pull request #5740:
URL: https://github.com/apache/incubator-pinot/pull/5740#discussion_r460318552
##########
File path: thirdeye/thirdeye-frontend/app/utils/yaml-tools.js
##########
@@ -29,6 +28,20 @@ rules:
type: DATA_SLA # Alert if data is missing.
params:
sla: 3_DAYS # Data is missing for 3 days since last
availability
+
+# You can mention a cron to allow this detection to be run periodically
+# For example, the cron below would execute every 5 minutes.
+# cron: "0 0/5 * 1/1 * ? *"
+
+# Backfill detections
+# You can use the backfillStart parameter to denote how far back you want the
anomalies
+# to be detected.
+# A valid entry is a timestamp value in millis.
+#
+# - By default, (if not mentioned), the lookback is 30 days
+# - A value of 0 (zero) implies complete backfill till the start of data. As
shown below.
+# backfillStart: 0
Review comment:
Couple of issues/suggestions
1. There is an api through which you can trigger a replay or backfill. You
might want to consider exposing this api to the user. It is better to keep the
alert creation independent of backfill. 30 days is hard-coded just to populate
some metrics on the UI for users to play around.
2. If you haven't explored yet, there is a preview experience through which
users can trigger detection on older data. However, this is adhoc and there is
no option of saving the results. You can consider adding the option of
persisting the results!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
