akshayrai commented on a change in pull request #5740:
URL: https://github.com/apache/incubator-pinot/pull/5740#discussion_r460318266
##########
File path: thirdeye/thirdeye-frontend/app/utils/yaml-tools.js
##########
@@ -29,6 +28,20 @@ rules:
type: DATA_SLA # Alert if data is missing.
params:
sla: 3_DAYS # Data is missing for 3 days since last
availability
+
+# You can mention a cron to allow this detection to be run periodically
+# For example, the cron below would execute every 5 minutes.
+# cron: "0 0/5 * 1/1 * ? *"
+
+# Backfill detections
+# You can use the backfillStart parameter to denote how far back you want the
anomalies
+# to be detected.
+# A valid entry is a timestamp value in millis.
+#
+# - By default, (if not mentioned), the lookback is 30 days
+# - A value of 0 (zero) implies complete backfill till the start of data. As
shown below.
+# backfillStart: 0
+
Review comment:
I understand. We too discussed this idea in the past, but the issue with
this approach is that - There are several basic alert and subscription
parameters which we might want to add to the template and this will simply keep
growing over time making the config bigger and harder to read.
To help with this problem, the alternative we have taken is,
a. A link is provided in the create alert UI (at the top) that should point
to the documentation on the alert configs. (I can work on OS'ing this wiki if
it isn't already)
b. Eventually, we should have a full form UI through which all the basic
features should be surfaced. The yaml config is more for advanced users who can
refer to a doc and update the configs as required.
So, it would be better to keep the template simple and put the additional
settings in the doc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
