suvodeep-pyne commented on a change in pull request #5740: URL: https://github.com/apache/incubator-pinot/pull/5740#discussion_r459691900
########## File path: thirdeye/thirdeye-frontend/app/utils/yaml-tools.js ########## @@ -29,6 +28,20 @@ rules: type: DATA_SLA # Alert if data is missing. params: sla: 3_DAYS # Data is missing for 3 days since last availability + +# You can mention a cron to allow this detection to be run periodically +# For example, the cron below would execute every 5 minutes. +# cron: "0 0/5 * 1/1 * ? *" + +# Backfill detections +# You can use the backfillStart parameter to denote how far back you want the anomalies +# to be detected. +# A valid entry is a timestamp value in millis. +# +# - By default, (if not mentioned), the lookback is 30 days +# - A value of 0 (zero) implies complete backfill till the start of data. As shown below. +# backfillStart: 0 Review comment: Agreed. But I found this to be the easiest way of having this capability without a larger change. So, here is the use case: I uploaded a new dataset and I want to see the anomalies. I was unable to find a way to do this. Creating an alert would trigger detections for the past month but not before that. It is not configurable. And I couldn't find a way to just fire a detection from the UI. This parameter allows the user to have the ability to use a default or choose a start time at the creation of the alert. I agree with you that creating an alert rule and running detection can be separated. This change sort of addresses the immediate requirement that allows users to upload their datasets and run detections on past data. Let me know what you think. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org