suvodeep-pyne commented on a change in pull request #5740:
URL: https://github.com/apache/incubator-pinot/pull/5740#discussion_r459686686
##########
File path: thirdeye/thirdeye-frontend/app/utils/yaml-tools.js
##########
@@ -29,6 +28,20 @@ rules:
type: DATA_SLA # Alert if data is missing.
params:
sla: 3_DAYS # Data is missing for 3 days since last
availability
+
+# You can mention a cron to allow this detection to be run periodically
+# For example, the cron below would execute every 5 minutes.
+# cron: "0 0/5 * 1/1 * ? *"
+
+# Backfill detections
Review comment:
Yes. That is a side effect but it happens today anyway. Whenever, you
create an alert, you run the detection for the past month every time. This
parameter just exposes the ability to configure the same.
But I totally agree on having separate atomic APIs in the longer term for
creating alerts, doing detections and saving them. Currently the preview runs
detections but does not save them. Creating an alert also fires detections but
doesn't allow configuring the detection. Also, it doesn't seem to be possible
to create a new alert without triggering a detectionjob.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
