Jackie-Jiang opened a new pull request #5625:
URL: https://github.com/apache/incubator-pinot/pull/5625
Motivation:
Currently DataSource is modeled as an Operator, where values are returned
as a block complying with the Operator interface. This is confusing because
of the following reasons:
- The block contains all the documents in the segment, instead of a block
of at most 10000 documents as in the Projection layer.
- The values are always fetched with their document ids, instead of fetched
as a block. Currently BlockValSet interface has 2 set of APIs because of
this, which is confusing.
- The BlockValSet returned by the DataSource is not really a value set, but
a value reader on top of the forward index.
- Extra BlockMetadata has to be maintained which can cause unexpected
problems (e.g. the issue fixed in #5619)
Changes:
- Make DataSource standalong without implementing Operator
- Add interfaces for forward index (ForwardIndexReader, ForwardIndexWriter,
ForwardIndexReaderWriter)
- Add ColumnValueReader class to help read forward index from DataSource
- Remove the docId based APIs from BlockValSet
## Description
Add a description of your PR here.
A good description should include pointers to an issue or design document,
etc.
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete
the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and
complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to
consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and
complete the section on Release Notes)
## Release Notes
If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of
the
next release.
If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text
## Documentation
If you have introduced a new feature or configuration, please add it to the
documentation as well.
See
https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
