xiangfu0 commented on code in PR #17995:
URL: https://github.com/apache/pinot/pull/17995#discussion_r3005907256
##########
pinot-plugins/pinot-input-format/pinot-confluent-protobuf/pom.xml:
##########
@@ -53,6 +53,10 @@
<groupId>io.confluent</groupId>
<artifactId>kafka-schema-registry-client</artifactId>
</dependency>
+ <dependency>
Review Comment:
jsr305 is already transitively available to all core modules via Guava in
pinot-spi (`guava -> jsr305:3.0.2:compile`). The reason
pinot-confluent-protobuf needs it explicitly is that plugin modules declare
pinot-spi with `provided` scope, which makes its transitive dependencies
(including jsr305 via Guava) unavailable at compile time.
So adding jsr305 to pinot-spi explicitly wouldn't change anything for
plugins — they'd still need their own declaration. The current approach
(explicit jsr305 with `provided` scope in this plugin module) is the minimal
correct fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
