xiangfu0 commented on code in PR #17995:
URL: https://github.com/apache/pinot/pull/17995#discussion_r3005783246
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManagerDistributedLockingTest.java:
##########
@@ -1011,7 +1011,8 @@ public void testForceReleaseLockDuringTaskExecution()
throws Exception {
public void testForceReleaseLockWhenNoLockExists() throws Exception {
// Setup controller with distributed locking enabled
Map<String, Object> properties = getDefaultControllerConfiguration();
-
properties.put(ControllerConf.ControllerPeriodicTasksConf.PINOT_TASK_MANAGER_SCHEDULER_ENABLED,
true);
+ // Keep the scheduler disabled so the test can assert against an otherwise
idle lock state.
+
properties.put(ControllerConf.ControllerPeriodicTasksConf.PINOT_TASK_MANAGER_SCHEDULER_ENABLED,
false);
Review Comment:
No, it was not related. Already reverted in commit b53608ccf1.
##########
pinot-plugins/pinot-input-format/pinot-confluent-protobuf/pom.xml:
##########
@@ -53,6 +53,10 @@
<groupId>io.confluent</groupId>
<artifactId>kafka-schema-registry-client</artifactId>
</dependency>
+ <dependency>
Review Comment:
Yes, it is necessary. The module directly uses `@Nullable` from
`javax.annotation` in `KafkaConfluentSchemaRegistryProtoBufMessageDecoder.java`
(4 usages). Without it, compilation fails with 5 errors. After protobuf 4.x,
`protobuf-java` no longer transitively pulls in jsr305 at compile scope.
That said, I've added `<scope>provided</scope>` since it's only needed at
compile time for annotations and shouldn't be bundled into the shaded plugin
JAR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
