Copilot commented on code in PR #17995: URL: https://github.com/apache/pinot/pull/17995#discussion_r2999039804
########## pinot-plugins/pinot-input-format/pinot-confluent-protobuf/pom.xml: ########## @@ -32,6 +32,7 @@ <url>https://pinot.apache.org/</url> <properties> <pinot.root>${basedir}/../../..</pinot.root> + <pinot.confluent.protobuf.version>3.25.9</pinot.confluent.protobuf.version> <shade.phase.prop>package</shade.phase.prop> Review Comment: The PR description says the fix is to add an explicit JSR-305 dependency for javax.annotation types after upgrading the shared protobuf version, but this module pom also pins a separate protobuf tool/runtime version (3.25.9), excludes protobuf artifacts from upstream deps, and adds a new shade relocation for com.google.protobuf. Please update the PR description (or revert these extra changes) so reviewers/users understand that pinot-confluent-protobuf is intentionally staying on/shading a protobuf 3.x line rather than using the shared protobuf 4.x version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
