Jackie-Jiang commented on code in PR #17995:
URL: https://github.com/apache/pinot/pull/17995#discussion_r3003335671
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManagerDistributedLockingTest.java:
##########
@@ -1011,7 +1011,8 @@ public void testForceReleaseLockDuringTaskExecution()
throws Exception {
public void testForceReleaseLockWhenNoLockExists() throws Exception {
// Setup controller with distributed locking enabled
Map<String, Object> properties = getDefaultControllerConfiguration();
-
properties.put(ControllerConf.ControllerPeriodicTasksConf.PINOT_TASK_MANAGER_SCHEDULER_ENABLED,
true);
+ // Keep the scheduler disabled so the test can assert against an otherwise
idle lock state.
+
properties.put(ControllerConf.ControllerPeriodicTasksConf.PINOT_TASK_MANAGER_SCHEDULER_ENABLED,
false);
Review Comment:
Is this related?
##########
pinot-plugins/pinot-input-format/pinot-confluent-protobuf/pom.xml:
##########
@@ -53,6 +53,10 @@
<groupId>io.confluent</groupId>
<artifactId>kafka-schema-registry-client</artifactId>
</dependency>
+ <dependency>
Review Comment:
Is this necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
