krishan1390 commented on code in PR #17443:
URL: https://github.com/apache/pinot/pull/17443#discussion_r2664858782
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/readers/PinotSegmentColumnReaderFactory.java:
##########
@@ -58,21 +59,26 @@ public class PinotSegmentColumnReaderFactory implements
ColumnReaderFactory {
* @param indexSegment Source segment to read from
*/
public PinotSegmentColumnReaderFactory(IndexSegment indexSegment) {
- this(indexSegment, true);
+ this(indexSegment, false, true);
}
/**
* Create a PinotSegmentColumnReaderFactory.
*
* @param indexSegment Source segment to read from
+ * @param skipDefaultNullValues Whether to read null values as default
values or as nulls
+ * If true, nulls will be read as nulls.
+ * If false, nulls will be read as default
values.
* @param initializeDefaultValueReaders Whether to initialize default value
readers for missing columns
* TODO - Ideally this factory shouldn't initialize default value
readers.
* The clients of this factory should decide whether to
create default value readers or not.
* This parameter is kept for backward compatibility and
will be removed in future.
*/
- public PinotSegmentColumnReaderFactory(IndexSegment indexSegment, boolean
initializeDefaultValueReaders) {
+ public PinotSegmentColumnReaderFactory(IndexSegment indexSegment, boolean
skipDefaultNullValues,
Review Comment:
Adding the new variable in the middle because initialize default value
readers will get deprecated in the future. Also, this is a new method added by
me and not yet used, so it shouldn't cause any backward incompatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
