krishan1390 commented on code in PR #17443:
URL: https://github.com/apache/pinot/pull/17443#discussion_r2664853101
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/readers/PinotSegmentColumnarDataSource.java:
##########
@@ -32,12 +33,16 @@ public class PinotSegmentColumnarDataSource implements
ColumnarDataSource {
private final IndexSegment _indexSegment;
private final int _totalDocs;
- private final boolean _initializeDefaultValueReaders;
+ private final RoaringBitmap _validDocIds;
- public PinotSegmentColumnarDataSource(IndexSegment indexSegment, boolean
initializeDefaultValueReaders) {
+ /**
+ * @param indexSegment Source segment to read from
+ *
+ */
+ public PinotSegmentColumnarDataSource(IndexSegment indexSegment,
RoaringBitmap validDocIds) {
Review Comment:
the backward incomaptibility is fine as this class is unused and recently
added by me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
