krishan1390 commented on code in PR #17443:
URL: https://github.com/apache/pinot/pull/17443#discussion_r2664855292
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/readers/PinotSegmentColumnarDataSource.java:
##########
@@ -47,13 +52,18 @@ public int getTotalDocs() {
@Override
public ColumnReaderFactory createColumnReaderFactory() {
- return new PinotSegmentColumnReaderFactory(_indexSegment,
_initializeDefaultValueReaders);
+ return new PinotSegmentColumnReaderFactory(_indexSegment, true, false);
Review Comment:
we're setting these flags by default based on their appropriate use case.
No client is yet using PinotSegmentColumnarDataSource for this to be a
problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
